]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
iio: chemical: scd4x: fix reported channel endianness
authorFiona Klute <fiona.klute@gmx.de>
Sat, 13 Dec 2025 16:32:26 +0000 (17:32 +0100)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sun, 21 Dec 2025 19:04:03 +0000 (19:04 +0000)
The driver converts values read from the sensor from BE to CPU
endianness in scd4x_read_meas(). The result is then pushed into the
buffer in scd4x_trigger_handler(), so on LE architectures parsing the
buffer using the reported BE type gave wrong results.

scd4x_read_raw() which provides sysfs *_raw values is not affected, it
used the values returned by scd4x_read_meas() without further
conversion.

Fixes: 49d22b695cbb6 ("drivers: iio: chemical: Add support for Sensirion SCD4x CO2 sensor")
Signed-off-by: Fiona Klute <fiona.klute@gmx.de>
Reviewed-by: David Lechner <dlechner@baylibre.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/chemical/scd4x.c

index 8859f89fb2a942d940b1ba7adf202977df7b4ad6..0fd839176e264e34a37c1e31a5fa58849ff748be 100644 (file)
@@ -584,7 +584,7 @@ static const struct iio_chan_spec scd4x_channels[] = {
                        .sign = 'u',
                        .realbits = 16,
                        .storagebits = 16,
-                       .endianness = IIO_BE,
+                       .endianness = IIO_CPU,
                },
        },
        {
@@ -599,7 +599,7 @@ static const struct iio_chan_spec scd4x_channels[] = {
                        .sign = 'u',
                        .realbits = 16,
                        .storagebits = 16,
-                       .endianness = IIO_BE,
+                       .endianness = IIO_CPU,
                },
        },
        {
@@ -612,7 +612,7 @@ static const struct iio_chan_spec scd4x_channels[] = {
                        .sign = 'u',
                        .realbits = 16,
                        .storagebits = 16,
-                       .endianness = IIO_BE,
+                       .endianness = IIO_CPU,
                },
        },
 };