promisor-remote: refactor initialising field lists

In "promisor-remote.c", the fields_sent() and fields_checked()
functions serve similar purposes and contain a small amount of
duplicated code.

As we are going to add a similar function in a following commit,
let's refactor this common code into a new initialize_fields_list()
function.

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/promisor-remote.c b/promisor-remote.c
index 77ebf537e2b3ee3eb9904d3b904badf9c9e64e0e..5d8151cedb59ff4d6162c2a5a808ef8208ce5bd4 100644 (file)
--- a/promisor-remote.c
+++ b/promisor-remote.c
@@ -375,18 +375,24 @@ static char *fields_from_config(struct string_list *fields_list, const char *con
        return fields;
 }
 
+static struct string_list *initialize_fields_list(struct string_list *fields_list, int *initialized,
+                                                 const char *config_key)
+{
+       if (!*initialized) {
+               fields_list->cmp = strcasecmp;
+               fields_from_config(fields_list, config_key);
+               *initialized = 1;
+       }
+
+       return fields_list;
+}
+
 static struct string_list *fields_sent(void)
 {
        static struct string_list fields_list = STRING_LIST_INIT_NODUP;
        static int initialized;
 
-       if (!initialized) {
-               fields_list.cmp = strcasecmp;
-               fields_from_config(&fields_list, "promisor.sendFields");
-               initialized = 1;
-       }
-
-       return &fields_list;
+       return initialize_fields_list(&fields_list, &initialized, "promisor.sendFields");
 }
 
 static struct string_list *fields_checked(void)
@@ -394,13 +400,7 @@ static struct string_list *fields_checked(void)
        static struct string_list fields_list = STRING_LIST_INIT_NODUP;
        static int initialized;
 
-       if (!initialized) {
-               fields_list.cmp = strcasecmp;
-               fields_from_config(&fields_list, "promisor.checkFields");
-               initialized = 1;
-       }
-
-       return &fields_list;
+       return initialize_fields_list(&fields_list, &initialized, "promisor.checkFields");
 }
 
 /*