]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
media: i2c: ds90ub960: Remove of_node assignment
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Wed, 16 Apr 2025 07:01:37 +0000 (10:01 +0300)
committerWolfram Sang <wsa+renesas@sang-engineering.com>
Wed, 16 Apr 2025 16:08:56 +0000 (18:08 +0200)
Remove of_node assignment which duplicates fwnode in struct i2c_board_info.
In general drivers must not set both, it's quite confusing. The I²C core
will consider fwnode with a priority and of_node is subject to remove from
above mentioned data structure.

Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Tested-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
drivers/media/i2c/ds90ub960.c

index 5dde8452739b64dd5b847a7bc1dac556ea43ca6c..5afdbbad9ff4faa32cb33c0a5bf5920192281041 100644 (file)
@@ -1682,7 +1682,6 @@ static int ub960_rxport_add_serializer(struct ub960_data *priv, u8 nport)
        struct device *dev = &priv->client->dev;
        struct ds90ub9xx_platform_data *ser_pdata = &rxport->ser.pdata;
        struct i2c_board_info ser_info = {
-               .of_node = to_of_node(rxport->ser.fwnode),
                .fwnode = rxport->ser.fwnode,
                .platform_data = ser_pdata,
        };