winbind: move config-reloading code to winbindd_dual.c

In preperation of forwarding MSG_SMB_CONF_UPDATED to all childs.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14602

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

diff --git a/source3/winbindd/winbindd.c b/source3/winbindd/winbindd.c
index bff5b9a72829b3db4ccf704b9625f69fe6665966..9ae7912b9ff9614b8f71797ee84c659739264d6f 100644 (file)
--- a/source3/winbindd/winbindd.c
+++ b/source3/winbindd/winbindd.c
@@ -103,7 +103,7 @@ struct imessaging_context *winbind_imessaging_context(void)
 
 /* Reload configuration */
 
-static bool reload_services_file(const char *lfile)
+bool winbindd_reload_services_file(const char *lfile)
 {
        const struct loadparm_substitution *lp_sub =
                loadparm_s3_global_substitution();
@@ -157,7 +157,7 @@ static void winbindd_status(void)
 
 /* Flush client cache */
 
-static void flush_caches(void)
+void winbindd_flush_caches(void)
 {
        /* We need to invalidate cached user list entries on a SIGHUP 
            otherwise cached access denied errors due to restrict anonymous
@@ -364,7 +364,7 @@ static void winbindd_sig_hup_handler(struct tevent_context *ev,
 
        DEBUG(1,("Reloading services after SIGHUP\n"));
        flush_caches_noinit();
-       reload_services_file(file);
+       winbindd_reload_services_file(file);
 }
 
 bool winbindd_setup_sig_hup_handler(const char *lfile)
@@ -448,18 +448,6 @@ static bool winbindd_setup_sig_usr2_handler(void)
        return true;
 }
 
-/* React on 'smbcontrol winbindd reload-config' in the same way as on SIGHUP*/
-static void msg_reload_services(struct messaging_context *msg,
-                               void *private_data,
-                               uint32_t msg_type,
-                               struct server_id server_id,
-                               DATA_BLOB *data)
-{
-        /* Flush various caches */
-       flush_caches();
-       reload_services_file((const char *) private_data);
-}
-
 /* React on 'smbcontrol winbindd shutdown' in the same way as on SIGTERM*/
 static void msg_shutdown(struct messaging_context *msg,
                         void *private_data,
@@ -1421,7 +1409,8 @@ static void winbindd_register_handlers(struct messaging_context *msg_ctx,
        /* React on 'smbcontrol winbindd reload-config' in the same way
           as to SIGHUP signal */
        messaging_register(msg_ctx, NULL,
-                          MSG_SMB_CONF_UPDATED, msg_reload_services);
+                          MSG_SMB_CONF_UPDATED,
+                          winbindd_msg_reload_services_parent);
        messaging_register(msg_ctx, NULL,
                           MSG_SHUTDOWN, msg_shutdown);
 
@@ -1812,7 +1801,7 @@ int main(int argc, const char **argv)
                exit(1);
        }
 
-       if (!reload_services_file(NULL)) {
+       if (!winbindd_reload_services_file(NULL)) {
                DEBUG(0, ("error opening config file\n"));
                exit(1);
        }

diff --git a/source3/winbindd/winbindd_dual.c b/source3/winbindd/winbindd_dual.c
index a93a987df076f4d15da9d31fd50fdaca7bcae4fc..2885dd4d00578a6d767377988810c9c847864391 100644 (file)
--- a/source3/winbindd/winbindd_dual.c
+++ b/source3/winbindd/winbindd_dual.c
@@ -929,6 +929,21 @@ void winbind_disconnect_dc_parent(struct messaging_context *msg_ctx,
        forall_children(winbind_msg_relay_fn, &state);
 }
 
+/* React on 'smbcontrol winbindd reload-config' in the same way as on SIGHUP*/
+void winbindd_msg_reload_services_parent(struct messaging_context *msg,
+                                        void *private_data,
+                                        uint32_t msg_type,
+                                        struct server_id server_id,
+                                        DATA_BLOB *data)
+{
+       DBG_DEBUG("Got reload-config message\n");
+
+        /* Flush various caches */
+       winbindd_flush_caches();
+
+       winbindd_reload_services_file((const char *)private_data);
+}
+
 /* Set our domains as offline and forward the offline message to our children. */
 
 struct winbind_msg_on_offline_state {

diff --git a/source3/winbindd/winbindd_proto.h b/source3/winbindd/winbindd_proto.h
index 0f5c773e851df78e4ddaa6ac0fb9d338c0b6324d..8923bb3124f95e55af47c843a2b7af55cba0a4a5 100644 (file)
--- a/source3/winbindd/winbindd_proto.h
+++ b/source3/winbindd/winbindd_proto.h
@@ -31,6 +31,8 @@ bool winbindd_setup_sig_hup_handler(const char *lfile);
 bool winbindd_use_idmap_cache(void);
 bool winbindd_use_cache(void);
 char *get_winbind_priv_pipe_dir(void);
+void winbindd_flush_caches(void);
+bool winbindd_reload_services_file(const char *lfile);
 
 /* The following definitions come from winbindd/winbindd_ads.c  */
 
@@ -341,6 +343,11 @@ void winbind_msg_ip_dropped_parent(struct messaging_context *msg_ctx,
                                   uint32_t msg_type,
                                   struct server_id server_id,
                                   DATA_BLOB *data);
+void winbindd_msg_reload_services_parent(struct messaging_context *msg,
+                                        void *private_data,
+                                        uint32_t msg_type,
+                                        struct server_id server_id,
+                                        DATA_BLOB *data);
 NTSTATUS winbindd_reinit_after_fork(const struct winbindd_child *myself,
                                    const char *logfilename);
 struct winbindd_domain *wb_child_domain(void);