ksmbd: fix Out-of-Bounds Read in ksmbd_vfs_stream_read

commit fc342cf86e2dc4d2edb0fc2ff5e28b6c7845adb9 upstream.

An offset from client could be a negative value, It could lead
to an out-of-bounds read from the stream_buf.
Note that this issue is coming when setting
'vfs objects = streams_xattr parameter' in ksmbd.conf.

Cc: stable@vger.kernel.org # v5.15+
Reported-by: Jordy Zomer <jordyzomer@google.com>
Signed-off-by: Jordy Zomer <jordyzomer@google.com>
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c
index 599118aed20539aeb35f6e5ff7dccb52fa2b66f3..ce6dff5c7d741c466752400099ffe43da949a11d 100644 (file)
--- a/fs/smb/server/smb2pdu.c
+++ b/fs/smb/server/smb2pdu.c
@@ -6651,6 +6651,10 @@ int smb2_read(struct ksmbd_work *work)
        }
 
        offset = le64_to_cpu(req->Offset);
+       if (offset < 0) {
+               err = -EINVAL;
+               goto out;
+       }
        length = le32_to_cpu(req->Length);
        mincount = le32_to_cpu(req->MinimumCount);