]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
drm/amdgpu: reset psp->cmd to NULL after releasing the buffer
authorJiang Liu <gerry@linux.alibaba.com>
Fri, 7 Feb 2025 06:28:49 +0000 (14:28 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 4 Jun 2025 12:40:14 +0000 (14:40 +0200)
[ Upstream commit e92f3f94cad24154fd3baae30c6dfb918492278d ]

Reset psp->cmd to NULL after releasing the buffer in function psp_sw_fini().

Reviewed-by: Lijo Lazar <lijo.lazar@amd.com>
Signed-off-by: Jiang Liu <gerry@linux.alibaba.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c

index f8740ad08af4182d24acaa56f74b6e3faef78648..a176b1da03bd36f9cf601bc37529b407c46682a6 100644 (file)
@@ -484,7 +484,6 @@ static int psp_sw_fini(void *handle)
 {
        struct amdgpu_device *adev = (struct amdgpu_device *)handle;
        struct psp_context *psp = &adev->psp;
-       struct psp_gfx_cmd_resp *cmd = psp->cmd;
 
        psp_memory_training_fini(psp);
        if (psp->sos_fw) {
@@ -511,8 +510,8 @@ static int psp_sw_fini(void *handle)
            adev->ip_versions[MP0_HWIP][0] == IP_VERSION(11, 0, 7))
                psp_sysfs_fini(adev);
 
-       kfree(cmd);
-       cmd = NULL;
+       kfree(psp->cmd);
+       psp->cmd = NULL;
 
        psp_free_shared_bufs(psp);