]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commitdiff
further order_by: order_by() with no arguments should not affect the current order_b...
authorMike Bayer <mike_mp@zzzcomputing.com>
Mon, 3 Apr 2006 17:49:41 +0000 (17:49 +0000)
committerMike Bayer <mike_mp@zzzcomputing.com>
Mon, 3 Apr 2006 17:49:41 +0000 (17:49 +0000)
lib/sqlalchemy/sql.py

index 39888fe2adfb06cb2a89fa0226d20e0ff840d764..816fac37818b24139dc24752b7f59262e616a89f 100644 (file)
@@ -1145,14 +1145,14 @@ class TableClause(FromClause):
 class SelectBaseMixin(object):
     """base class for Select and CompoundSelects"""
     def order_by(self, *clauses):
-        if len(clauses) == 0 or clauses[0] is None:
+        if len(clauses) == 1 and clauses[0] is None:
             self.order_by_clause = ClauseList()
         elif getattr(self, 'order_by_clause', None):
             self.order_by_clause = ClauseList(*(list(self.order_by_clause.clauses) + list(clauses)))
         else:
             self.order_by_clause = ClauseList(*clauses)
     def group_by(self, *clauses):
-        if len(clauses) == 0 or clauses[0] is None:
+        if len(clauses) == 1 and clauses[0] is None:
             self.group_by_clause = ClauseList()
         elif getattr(self, 'group_by_clause', None):
             self.group_by_clause = ClauseList(*(list(clauses)+list(self.group_by_clause.clauses)))