]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
iio: light: si1133: add local variable for timeout
authorJoshua Crofts <joshua.crofts1@gmail.com>
Tue, 5 May 2026 07:31:32 +0000 (09:31 +0200)
committerJonathan Cameron <jic23@kernel.org>
Sun, 31 May 2026 09:59:34 +0000 (10:59 +0100)
Add local variable for timeout to improve readability.

No functional change.

Suggested-by: Jonathan Cameron <jic23@kernel.org>
Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
drivers/iio/light/si1133.c

index fdffdee16e493277d95c369ec2f6c0678cf9f61c..ef5c38e303a6eca219345794dc0a1d7fb2ee769f 100644 (file)
@@ -390,6 +390,7 @@ static int si1133_cmd_reset_counter(struct si1133_data *data)
 
 static int si1133_command(struct si1133_data *data, u8 cmd)
 {
+       unsigned long timeout;
        struct device *dev = &data->client->dev;
        u32 resp;
        int err;
@@ -417,8 +418,8 @@ static int si1133_command(struct si1133_data *data, u8 cmd)
 
        if (cmd == SI1133_CMD_FORCE) {
                /* wait for irq */
-               if (!wait_for_completion_timeout(&data->completion,
-                       msecs_to_jiffies(SI1133_COMPLETION_TIMEOUT_MS))) {
+               timeout = msecs_to_jiffies(SI1133_COMPLETION_TIMEOUT_MS);
+               if (!wait_for_completion_timeout(&data->completion, timeout)) {
                        regmap_write(data->regmap, SI1133_REG_IRQ_ENABLE, 0);
                        err = -ETIMEDOUT;
                        goto out;