]> git.ipfire.org Git - thirdparty/pdns.git/commitdiff
dnsdist: Remove a second useless check, useless static casts 13116/head
authorRemi Gacogne <remi.gacogne@powerdns.com>
Tue, 15 Aug 2023 16:07:52 +0000 (18:07 +0200)
committerRemi Gacogne <remi.gacogne@powerdns.com>
Wed, 23 Aug 2023 07:43:15 +0000 (09:43 +0200)
(cherry picked from commit 6f0a2aec1d935a59f71ac8dfb6b8c174726071c2)

pdns/dnsdistdist/dnsdist-discovery.cc

index 390fce820e62f8e22a72a24b22b4f18822ba6f2e..76042e3c8de476e17f2881a3ca40815e934c2e53 100644 (file)
@@ -275,7 +275,7 @@ bool ServiceDiscovery::getDiscoveredConfig(const UpgradeableBackend& upgradeable
     const struct timeval remainingTime = {.tv_sec = backend->d_config.tcpRecvTimeout, .tv_usec = 0};
     uint16_t responseSize = 0;
     auto got = readn2WithTimeout(sock.getHandle(), &responseSize, sizeof(responseSize), remainingTime);
-    if (static_cast<size_t>(got) != sizeof(responseSize)) {
+    if (got != sizeof(responseSize)) {
       if (g_verbose) {
         warnlog("Error while waiting for the ADD upgrade response size from backend %s: %d", addr.toStringWithPort(), got);
       }
@@ -285,7 +285,7 @@ bool ServiceDiscovery::getDiscoveredConfig(const UpgradeableBackend& upgradeable
     packet.resize(ntohs(responseSize));
 
     got = readn2WithTimeout(sock.getHandle(), packet.data(), packet.size(), remainingTime);
-    if (got < 0 || static_cast<size_t>(got) != packet.size()) {
+    if (got != packet.size()) {
       if (g_verbose) {
         warnlog("Error while waiting for the ADD upgrade response from backend %s: %d", addr.toStringWithPort(), got);
       }