]> git.ipfire.org Git - thirdparty/asterisk.git/commitdiff
The meetme CLI command completion leaves conferences mutex locked.
authorRichard Mudgett <rmudgett@digium.com>
Fri, 20 May 2011 20:38:22 +0000 (20:38 +0000)
committerRichard Mudgett <rmudgett@digium.com>
Fri, 20 May 2011 20:38:22 +0000 (20:38 +0000)
When issuing a meetme kick CLI command and an invalid (non-existent)
conference number is specified, pressing Tab leaves the conferences mutex
locked and, therefore, all conferences deadlock.

Add missing unlock.

(closes issue #19336)
Reported by: zvision
Patches:
      app_meetme.diff uploaded by zvision (license 798)

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@320235 65c4cc65-6c06-0410-ace0-fbb531ad65f3

apps/app_meetme.c

index 95291c0bb3f38a23a663a4367d8f086ab5ed7cce..ee98bc4b3447a6f4a0da70ab9335ab51a020170d 100644 (file)
@@ -1099,6 +1099,7 @@ static char *complete_meetmecmd(const char *line, const char *word, int pos, int
                                AST_LIST_UNLOCK(&confs);
                                return usr ? strdup(usrno) : NULL;
                        }
+                       AST_LIST_UNLOCK(&confs);
                } else if ( strstr(line, "list") && ( 0 == state ) )
                        return strdup("concise");
        }