]> git.ipfire.org Git - thirdparty/knot-resolver.git/commitdiff
ci: document confusing allow_failure: false
authorTomas Krizek <tomas.krizek@nic.cz>
Thu, 12 Dec 2019 16:19:29 +0000 (17:19 +0100)
committerTomas Krizek <tomas.krizek@nic.cz>
Thu, 12 Dec 2019 16:19:29 +0000 (17:19 +0100)
This value seems to be the default, but it is important to have
it set explicitly, otherwise when: manual actions could be skipped

https://docs.gitlab.com/ee/ci/yaml/#whenmanual

.gitlab-ci.yml

index 637a4cc0c2181278cef47c43f6dbc79c39b9e0a7..1772f4d66a1c6f8218af85ee6696a95bca733227 100644 (file)
@@ -456,7 +456,7 @@ obs:trigger: &obs_trigger
     url: https://build.opensuse.org/package/show/home:CZ-NIC:$OBS_REPO/knot-resolver
   tags:
     - respdiff
-  allow_failure: false
+  allow_failure: false  # required to make when: manual action blocking
   script:
     - scripts/make-distrofiles.sh
     - echo y | scripts/build-in-obs.sh $OBS_REPO