]> git.ipfire.org Git - thirdparty/patchwork.git/commitdiff
trivial: noqa any 'assert' functions
authorStephen Finucane <stephenfinucane@hotmail.com>
Mon, 19 Sep 2016 22:15:26 +0000 (23:15 +0100)
committerStephen Finucane <stephenfinucane@hotmail.com>
Sat, 24 Sep 2016 23:00:20 +0000 (00:00 +0100)
There are advantages to sticking with unittest's use of camel case in
function names, but some code tools don't like this. noqa these lines
to hide the warnings.

Signed-off-by: Stephen Finucane <stephenfinucane@hotmail.com>
Reviewed-by: Daniel Axtens <dja@axtens.net>
patchwork/tests/test_checks.py
patchwork/tests/test_parser.py
patchwork/tests/test_tags.py

index cb3dfcc712147a4adcf04e38961fb0ab25b25576..c0487f345b768b8b453ad216d5fabfffafdf4f6b 100644 (file)
@@ -43,12 +43,12 @@ class PatchChecksTest(TransactionTestCase):
 
         return create_check(**values)
 
-    def assertCheckEqual(self, patch, check_state):
+    def assertCheckEqual(self, patch, check_state):  # noqa
         state_names = dict(Check.STATE_CHOICES)
         self.assertEqual(self.patch.combined_check_state,
                          state_names[check_state])
 
-    def assertChecksEqual(self, patch, checks=None):
+    def assertChecksEqual(self, patch, checks=None):  # noqa
         if not checks:
             checks = []
 
@@ -57,7 +57,7 @@ class PatchChecksTest(TransactionTestCase):
             sorted(self.patch.checks, key=lambda check: check.id),
             sorted(checks, key=lambda check: check.id))
 
-    def assertCheckCountEqual(self, patch, total, state_counts=None):
+    def assertCheckCountEqual(self, patch, total, state_counts=None):  # noqa
         if not state_counts:
             state_counts = {}
 
index 7b5c71bbcee7b1e46466cc9d33d83b3ce23a4acc..9a739e4d16ce980fe77e95edb3e465dd6685315a 100644 (file)
@@ -554,7 +554,7 @@ class DelegateRequestTest(TestCase):
         email['Message-Id'] = self.msgid
         return email
 
-    def assertDelegate(self, delegate):
+    def assertDelegate(self, delegate):  # noqa
         query = Patch.objects.filter(project=self.project)
         self.assertEqual(query.count(), 1)
         self.assertEqual(query[0].delegate, delegate)
@@ -596,7 +596,7 @@ class InitialPatchStateTest(TestCase):
             self.patch, msgid=self.msgid, listid='<%s>' % self.project.listid)
         return email
 
-    def assertState(self, state):
+    def assertState(self, state):  # noqa
         query = Patch.objects.filter(project=self.project)
         self.assertEqual(query.count(), 1)
         self.assertEqual(query[0].state, state)
index 7d200e3e4c9c095220d9a6ccd6999dcace9fc9e4..4fd1bf23f14ea1cfa4f94dc8f89aadb2d19dfee7 100644 (file)
@@ -33,7 +33,7 @@ class ExtractTagsTest(TestCase):
     email = 'test@example.com'
     name_email = 'test name <' + email + '>'
 
-    def assertTagsEqual(self, str, acks, reviews, tests):
+    def assertTagsEqual(self, str, acks, reviews, tests):  # noqa
         counts = Patch.extract_tags(str, Tag.objects.all())
         self.assertEqual((acks, reviews, tests),
                          (counts[Tag.objects.get(name='Acked-by')],
@@ -92,7 +92,7 @@ class PatchTagsTest(TransactionTestCase):
         self.patch.project.use_tags = True
         self.patch.project.save()
 
-    def assertTagsEqual(self, patch, acks, reviews, tests):
+    def assertTagsEqual(self, patch, acks, reviews, tests):  # noqa
         patch = Patch.objects.get(pk=patch.pk)
 
         def count(name):
@@ -183,7 +183,7 @@ class PatchTagsTest(TransactionTestCase):
 
 class PatchTagManagerTest(PatchTagsTest):
 
-    def assertTagsEqual(self, patch, acks, reviews, tests):
+    def assertTagsEqual(self, patch, acks, reviews, tests):  # noqa
         tagattrs = {}
         for tag in Tag.objects.all():
             tagattrs[tag.name] = tag.attr_name