Fix mistaken free of domain event object after queueing (David Lively)

diff --git a/ChangeLog b/ChangeLog
index 2584bb01850fbffeb2ae46b221e5db0fcedb633f..849d74303fb2b884b7385267c0cf081ebe2278ff 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+Thu Dec 18 12:11:58 GMT 2008 Daniel P. Berrange <berrange@redhat.com>
+
+       * src/remote_internal.c: Don't free event after queueing it
+       unless error occurred (David Lively)
+
 Thu Dec 18 12:07:58 GMT 2008 Daniel P. Berrange <berrange@redhat.com>
 
        * src/test.c: Fix error return value

diff --git a/src/remote_internal.c b/src/remote_internal.c
index fcff3cd6ca0b7df2dd27e846237f6edbb0cd4997..2003a0e2c5ffb0ea852caaa4a2976f1322ed3b11 100644 (file)
--- a/src/remote_internal.c
+++ b/src/remote_internal.c
@@ -5535,10 +5535,10 @@ remoteDomainQueueEvent(virConnectPtr conn, XDR *xdr)
         return;
 
     if (virDomainEventQueuePush(priv->domainEvents,
-                                event) < 0)
+                                event) < 0) {
         DEBUG0("Error adding event to queue");
-
-    virDomainEventFree(event);
+        virDomainEventFree(event);
+    }
 }
 
 /** remoteDomainEventFired: