]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
ipa-cp: Avoid ICE when redistributing nodes among edges to recursive clones (PR 118318)
authorMartin Jambor <mjambor@suse.cz>
Fri, 7 Mar 2025 16:17:24 +0000 (17:17 +0100)
committerMartin Jambor <jamborm@gcc.gnu.org>
Tue, 25 Mar 2025 15:57:09 +0000 (16:57 +0100)
PR 118318 reported an ICE during PGO build of Firefox when IPA-CP, in
the final stages of update_counts_for_self_gen_clones where it
attempts to guess how to distribute profile count among clones created
for recursive edges and the various edges that are created in the
process.  If one such edge has profile count of kind GUESSED_GLOBAL0,
the compatibility check in the operator+ will lead to an ICE.  After
discussing the situation with Honza, we concluded that there is little
more we can do other than check for this situation before touching the
edge count, so this is what this patch does.

gcc/ChangeLog:

2025-02-28  Martin Jambor  <mjambor@suse.cz>

PR ipa/118318
* ipa-cp.cc (adjust_clone_incoming_counts): Add a compatible_p check.

(cherry picked from commit 7deb498425799aceb7659ea25614175a49533184)

gcc/ipa-cp.cc

index b7add455bd5d78b84dbd737bb5ff68c47e990335..6b772fae88ff7f0f31574a1ba17d6461d49a8a05 100644 (file)
@@ -4608,7 +4608,8 @@ adjust_clone_incoming_counts (cgraph_node *node,
        cs->count = cs->count.combine_with_ipa_count (sum);
       }
     else if (!desc->processed_edges->contains (cs)
-            && cs->caller->clone_of == desc->orig)
+            && cs->caller->clone_of == desc->orig
+            && cs->count.compatible_p (desc->count))
       {
        cs->count += desc->count;
        if (dump_file)