Enable aggressive warning options, -Wextra -Wunused -Wshadow -Wmissing-prototypes...

It helps us find out minor issues.

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 1714df0191417b7748404e47fa01f9be0699ec7a..8ad306fe4b0a4d32bdd0740973e57b674d45bbdf 100644 (file)
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -51,7 +51,7 @@ SET(SOVERSION "${INTERFACE_VERSION}")
 # aggressive about diagnosing build problems; this can get
 # relaxed somewhat in final shipping versions.
 IF ("CMAKE_C_COMPILER_ID" MATCHES "^GNU$")
-  ADD_DEFINITIONS(-Wall -Werror)
+  ADD_DEFINITIONS(-Wall -Werror -Wextra -Wunused -Wshadow -Wmissing-prototypes -Wcast-qual)
   SET(CMAKE_REQUIRED_FLAGS "-Wall -Werror")
 ENDIF ("CMAKE_C_COMPILER_ID" MATCHES "^GNU$")
 

diff --git a/Makefile.am b/Makefile.am
index 5a30316c5a299dec4256d146518308dc328187d4..aa715bb11f2f090ccd0c1a3424c10d3593ac4b60 100644 (file)
--- a/Makefile.am
+++ b/Makefile.am
@@ -23,7 +23,7 @@ TESTS_ENVIRONMENT= $(libarchive_TESTS_ENVIRONMENT) $(bsdtar_TESTS_ENVIRONMENT) $
 DISTCHECK_CONFIGURE_FLAGS = --enable-bsdtar --enable-bsdcpio
 # The next line is commented out by default in shipping libarchive releases.
 # It is uncommented by default in trunk.
-AM_CFLAGS=-Wall -Werror
+AM_CFLAGS=-Wall -Werror -Wextra -Wunused -Wshadow -Wmissing-prototypes -Wcast-qual
 PLATFORMCPPFLAGS = @PLATFORMCPPFLAGS@
 AM_CPPFLAGS=$(PLATFORMCPPFLAGS)