]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
detect: fix memory leak in app-layer-event keyword
authorVictor Julien <victor@inliniac.net>
Wed, 4 Jul 2018 13:10:34 +0000 (15:10 +0200)
committerVictor Julien <victor@inliniac.net>
Mon, 16 Jul 2018 11:30:50 +0000 (13:30 +0200)
Bug #2515.

src/detect-app-layer-event.c

index 02e58560a138119eafeaeb60ad242a17e397423d..ed4f7fdc8d9fd4878cfb3ac30287921ec24435a0 100644 (file)
@@ -310,6 +310,9 @@ static int DetectAppLayerEventSetupP2(Signature *s,
     if (DetectAppLayerEventParseAppP2((DetectAppLayerEventData *)sm->ctx, s->proto.proto,
                                       &event_type) < 0) {
         /* DetectAppLayerEventParseAppP2 prints errors */
+
+        /* sm has been removed from lists by DetectAppLayerEventPrepare */
+        SigMatchFree(sm);
         return -1;
     }
     SigMatchAppendSMToList(s, sm, g_applayer_events_list_id);