]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
iio: adc: mcp320x: Fix alignment for DMA safety
authorJonathan Cameron <Jonathan.Cameron@huawei.com>
Sun, 8 May 2022 17:56:07 +0000 (18:56 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Aug 2022 12:41:27 +0000 (14:41 +0200)
[ Upstream commit e770f78036ce4327caf285873f4b20564a8b4f0f ]

____cacheline_aligned is an insufficient guarantee for non-coherent DMA
on platforms with 128 byte cachelines above L1.  Switch to the updated
IIO_DMA_MINALIGN definition.

Worth noting the fixes tag refers to the same issue being observed
on a platform that probably had only 64 byte cachelines.

Fixes: 0e81bc99a082 ("iio: mcp320x: Fix occasional incorrect readings")
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Michael Welling <mwelling@ieee.org>
Acked-by: Nuno Sá <nuno.sa@analog.com>
Link: https://lore.kernel.org/r/20220508175712.647246-28-jic23@kernel.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/iio/adc/mcp320x.c

index b4c69acb33e34b468902feed69ffa9f2aae83910..f3b81798b3c9351d90c7796866d39d1d053ad5b5 100644 (file)
@@ -92,7 +92,7 @@ struct mcp320x {
        struct mutex lock;
        const struct mcp320x_chip_info *chip_info;
 
-       u8 tx_buf ____cacheline_aligned;
+       u8 tx_buf __aligned(IIO_DMA_MINALIGN);
        u8 rx_buf[4];
 };