]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: Block disk hotplug when transient disk option is enabled
authorMasayoshi Mizuma <m.mizuma@jp.fujitsu.com>
Thu, 17 Sep 2020 13:30:41 +0000 (09:30 -0400)
committerPeter Krempa <pkrempa@redhat.com>
Thu, 1 Oct 2020 07:55:02 +0000 (09:55 +0200)
For now we disable disk hotplug of transient disk as it requires
creating an overlay prior to adding the frontend.

Signed-off-by: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Tested-by: Ján Tomko <jtomko@redhat.com>
src/qemu/qemu_hotplug.c

index fc0866c01187c3a9ae9b062cc3bdd77f00e684ea..ed4d1580fafa88b26261f2ceceb7a3d1b3191d52 100644 (file)
@@ -1031,6 +1031,12 @@ qemuDomainAttachDeviceDiskLiveInternal(virQEMUDriverPtr driver,
         return -1;
     }
 
+    if (disk->transient) {
+        virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
+                       _("transient disk hotplug isn't supported"));
+        return -1;
+    }
+
     if (virDomainDiskTranslateSourcePool(disk) < 0)
         goto cleanup;