]> git.ipfire.org Git - thirdparty/e2fsprogs.git/commitdiff
AOSP: misc: fix resource leak in populate_fs
authorJin Qian <jinqian@google.com>
Thu, 10 Aug 2017 18:11:09 +0000 (11:11 -0700)
committerTheodore Ts'o <tytso@mit.edu>
Mon, 26 Feb 2018 17:23:05 +0000 (12:23 -0500)
Contributed-By: Ivan Maidanski <i.maidanski@samsung.com>
Change-Id: Ibffdeea347d993c97f86ff7bfc5e78024048afce
From AOSP commit: 978002e04483ddab12187f2e08b28996657bc818

misc/create_inode.c

index fb0a88f7631b051994fa49512784753250fc3953..caa36095c44cbaee250cbe147fa7efe056ed9727 100644 (file)
@@ -778,8 +778,11 @@ static errcode_t __populate_fs(ext2_filsys fs, ext2_ino_t parent_ino,
 
                cur_dir_path_len = target->path_len;
                retval = path_append(target, name);
-               if (retval)
-                       return retval;
+               if (retval) {
+                       com_err(__func__, retval,
+                               "while appending %s", name);
+                       goto out;
+               }
 
                if (fs_callbacks && fs_callbacks->create_new_inode) {
                        retval = fs_callbacks->create_new_inode(fs,