domain_conf: make virDomainLeaseInsert() void

This function always returns zero, so it might as well be void.

Signed-off-by: Matt Coleman <matt@datto.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 4793a4dc4d81a9d4fa411311643e6de396f6305d..afd795bd1a464ba180b801184e0bc4c07e30dc93 100644 (file)
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -18277,13 +18277,10 @@ void virDomainLeaseInsertPreAlloc(virDomainDefPtr def)
     def->leases = g_renew(virDomainLeaseDefPtr, def->leases, def->nleases + 1);
 }
 
-int virDomainLeaseInsert(virDomainDefPtr def,
-                         virDomainLeaseDefPtr lease)
+void virDomainLeaseInsert(virDomainDefPtr def, virDomainLeaseDefPtr lease)
 {
     virDomainLeaseInsertPreAlloc(def);
-
     virDomainLeaseInsertPreAlloced(def, lease);
-    return 0;
 }
 
 

diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
index e6a315aa227a7541e04bf8ce583c9b89d900c073..77656c8ae371067e4f55af009ebfaea4992ec75d 100644 (file)
--- a/src/conf/domain_conf.h
+++ b/src/conf/domain_conf.h
@@ -3432,8 +3432,7 @@ const char *virDomainControllerAliasFind(const virDomainDef *def,
 
 int virDomainLeaseIndex(virDomainDefPtr def,
                         virDomainLeaseDefPtr lease);
-int virDomainLeaseInsert(virDomainDefPtr def,
-                         virDomainLeaseDefPtr lease);
+void virDomainLeaseInsert(virDomainDefPtr def, virDomainLeaseDefPtr lease);
 void virDomainLeaseInsertPreAlloc(virDomainDefPtr def);
 void virDomainLeaseInsertPreAlloced(virDomainDefPtr def,
                                     virDomainLeaseDefPtr lease);

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index a2371ea13c1df024ab6685adbf575bf72c141f7f..05f8eb2cb7614c20979ff092f795be731e2adb30 100644 (file)
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -7272,8 +7272,7 @@ qemuDomainAttachDeviceConfig(virDomainDefPtr vmdef,
                            lease->key, NULLSTR(lease->lockspace));
             return -1;
         }
-        if (virDomainLeaseInsert(vmdef, lease) < 0)
-            return -1;
+        virDomainLeaseInsert(vmdef, lease);
 
         /* vmdef has the pointer. Generic codes for vmdef will do all jobs */
         dev->data.lease = NULL;