]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
s390/page: Cleanup page_set_storage_key() inline assemblies
authorHeiko Carstens <hca@linux.ibm.com>
Mon, 16 Jun 2025 15:00:27 +0000 (17:00 +0200)
committerAlexander Gordeev <agordeev@linux.ibm.com>
Sun, 29 Jun 2025 11:12:01 +0000 (13:12 +0200)
Add extra lines, indentations, and symbolic names for operands in
order to make the two page_set_storage_key() inline assemblies a bit
more readable.

Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
Signed-off-by: Alexander Gordeev <agordeev@linux.ibm.com>
arch/s390/include/asm/page.h

index 4e5dbabdf202560dacd364772e1c6d6628252312..79db884b8e3e5e2c50779cb39b94cb7f52efe403 100644 (file)
@@ -130,11 +130,17 @@ typedef pte_t *pgtable_t;
 static inline void page_set_storage_key(unsigned long addr,
                                        unsigned char skey, int mapped)
 {
-       if (!mapped)
-               asm volatile(".insn rrf,0xb22b0000,%0,%1,8,0"
-                            : : "d" (skey), "a" (addr));
-       else
-               asm volatile("sske %0,%1" : : "d" (skey), "a" (addr));
+       if (!mapped) {
+               asm volatile(
+                       "       .insn   rrf,0xb22b0000,%[skey],%[addr],8,0"
+                       :
+                       : [skey] "d" (skey), [addr] "a" (addr));
+       } else {
+               asm volatile(
+                       "       sske     %[skey],%[addr]"
+                       :
+                       : [skey] "d" (skey), [addr] "a" (addr));
+       }
 }
 
 static inline unsigned char page_get_storage_key(unsigned long addr)