kernel-yocto.bbclass: Reset to exiting on non-zero return code at end of task

Several tasks deactivate exiting on non-zero return codes via set +e because
they run subcommands that have legitimate non-zero return codes. However when
appending to those tasks, this behavior is not expected and can lead to builds
silently proceeding in case of an error. Therefore reset the default behavior
at the end of the respective tasks via set -e.

Signed-off-by: Stefan Wiehler <stefan.wiehler@nokia.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

diff --git a/meta/classes/kernel-yocto.bbclass b/meta/classes/kernel-yocto.bbclass
index b276ded7751cad5934e91edcefd554b6e090cd98..ce1446f7aa33d59168894d72fbc38bd357410256 100644 (file)
--- a/meta/classes/kernel-yocto.bbclass
+++ b/meta/classes/kernel-yocto.bbclass
@@ -310,6 +310,8 @@ do_kernel_metadata() {
                bbnote "KERNEL_FEATURES: $KERNEL_FEATURES_FINAL"
                bbnote "Final scc/cfg list: $sccs_defconfig $bsp_definition $sccs $KERNEL_FEATURES_FINAL"
        fi
+
+       set -e
 }
 
 do_patch() {
@@ -343,6 +345,8 @@ do_patch() {
                        fi
                done
        fi
+
+       set -e
 }
 
 do_kernel_checkout() {
@@ -401,6 +405,8 @@ do_kernel_checkout() {
                git commit -q -m "baseline commit: creating repo for ${PN}-${PV}"
                git clean -d -f
        fi
+
+       set -e
 }
 do_kernel_checkout[dirs] = "${S} ${WORKDIR}"
 
@@ -695,6 +701,8 @@ do_validate_branches() {
                        kgit-s2q --clean
                fi
        fi
+
+       set -e
 }
 
 OE_TERMINAL_EXPORTS += "KBUILD_OUTPUT"