]> git.ipfire.org Git - thirdparty/public-inbox.git/commitdiff
t/filter_base: relax Regexp class match with ->isa
authorEric Wong <e@80x24.org>
Fri, 13 Dec 2024 18:36:31 +0000 (18:36 +0000)
committerEric Wong <e@80x24.org>
Wed, 18 Dec 2024 21:42:24 +0000 (21:42 +0000)
It would be nice to support alternative Regexp engines such
as re::engine::PCRE2 in the future.  The exact ref() name
can't match, however ->isa() works with re::engine::PCRE2.
So future-proof our code for potential changes in case PCRE2
becomes usable.

t/filter_base.t

index 2646321a8e715cee88e0213f49e8328cf965393f..3a0dbf8b8f41f2246a41e87c1642c0bb23bd4893 100644 (file)
@@ -10,7 +10,7 @@ use_ok 'PublicInbox::Filter::Base';
        my $f = PublicInbox::Filter::Base->new;
        ok($f, 'created stock object');
        ok(defined $f->{reject_suffix}, 'rejected suffix redefined');
-       is(ref($f->{reject_suffix}), 'Regexp', 'reject_suffix should be a RE');
+       ok $f->{reject_suffix}->isa('Regexp'), 'reject_suffix should be a RE';
 }
 
 {