]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
spi: rockchip: Use plain request_irq()
authorMark Brown <broonie@kernel.org>
Fri, 16 Jan 2026 13:23:40 +0000 (13:23 +0000)
committerMark Brown <broonie@kernel.org>
Mon, 19 Jan 2026 16:29:08 +0000 (16:29 +0000)
The Rockchip driver has since interrupt support was added used
request_threaded_irq() but not actually supplied a threaded handler,
handling everything in the primary handler.  This is equivalent to just
using a plain request_irq(), and since aef30c8d569c (genirq: Warn about
using IRQF_ONESHOT without a threaded handler) the current behaviour has
triggered a WARN_ON().  Convert to use request_irq().

Reported-by: Aishwarya TCV <Aishwarya.TCV@arm.com>
Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Link: https://patch.msgid.link/20260116-spi-rockchip-threaded-irq-v1-1-c45c3a5a38b1@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-rockchip.c

index 1a6381de6f33d7018eb00842fa9ee8cd8f1f01f7..62e1bc08c940fe9821837e4ed073f458692f2fe2 100644 (file)
@@ -805,8 +805,8 @@ static int rockchip_spi_probe(struct platform_device *pdev)
        if (ret < 0)
                goto err_put_ctlr;
 
-       ret = devm_request_threaded_irq(&pdev->dev, ret, rockchip_spi_isr, NULL,
-                                       IRQF_ONESHOT, dev_name(&pdev->dev), ctlr);
+       ret = devm_request_irq(&pdev->dev, ret, rockchip_spi_isr, 0,
+                              dev_name(&pdev->dev), ctlr);
        if (ret)
                goto err_put_ctlr;