]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
thermal/drivers/sprd: Fix temperature clamping in sprd_thm_temp_to_rawdata
authorThorsten Blum <thorsten.blum@linux.dev>
Sat, 7 Mar 2026 10:24:20 +0000 (11:24 +0100)
committerDaniel Lezcano <daniel.lezcano@kernel.org>
Mon, 9 Mar 2026 23:12:19 +0000 (00:12 +0100)
The temperature was never clamped to SPRD_THM_TEMP_LOW or
SPRD_THM_TEMP_HIGH because the return value of clamp() was not used. Fix
this by assigning the clamped value to 'temp'.

Casting SPRD_THM_TEMP_LOW and SPRD_THM_TEMP_HIGH to int is also
redundant and can be removed.

Fixes: 554fdbaf19b1 ("thermal: sprd: Add Spreadtrum thermal driver support")
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Signed-off-by: Daniel Lezcano <daniel.lezcano@kernel.org>
Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: stable@vger.kernel.org
Link: https://patch.msgid.link/20260307102422.306055-1-thorsten.blum@linux.dev
drivers/thermal/sprd_thermal.c

index e546067c962187bc8ef594bc520033c7561cd808..70c879e75d85cdbd8321ee160059fab02a011b5b 100644 (file)
@@ -192,7 +192,7 @@ static int sprd_thm_temp_to_rawdata(int temp, struct sprd_thermal_sensor *sen)
 {
        u32 val;
 
-       clamp(temp, (int)SPRD_THM_TEMP_LOW, (int)SPRD_THM_TEMP_HIGH);
+       temp = clamp(temp, SPRD_THM_TEMP_LOW, SPRD_THM_TEMP_HIGH);
 
        /*
         * According to the thermal datasheet, the formula of converting