test_common: eliminate call to non-existent cleanup_task

cleanup_task is long gone since all that cleanup work got moved
into DS itself.  Adding a DS->Reset here breaks t/imapd.t (and
possibly other tests), and is actually unlikely to avoid any
cleanup segfaults on OpenBSD since those are only happening
after `END {}' blocks are called.

diff --git a/lib/PublicInbox/TestCommon.pm b/lib/PublicInbox/TestCommon.pm
index a8323e4d946a582e8f16f59c5448e49cb9901c68..4c819a4ffc01567d76a3afba52fcf6ef86ea5090 100644 (file)
--- a/lib/PublicInbox/TestCommon.pm
+++ b/lib/PublicInbox/TestCommon.pm
@@ -365,7 +365,8 @@ sub run_script ($;$$) {
                        chdir $d or die "chdir $d: $!";
                }
                _run_sub($sub, $key, \@argv);
-               eval { PublicInbox::Inbox::cleanup_task() };
+               # n.b. all our uses of PublicInbox::DS should be fine
+               # with this and we can't Reset here.
                die "fchdir(restore): $!" if $cwdfh && !chdir($cwdfh);
                _undo_redirects($orig_io);
                select STDOUT;