]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
pinctrl: rp1: use new GPIO line value setter callbacks
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Sat, 19 Jul 2025 15:58:25 +0000 (17:58 +0200)
committerArnd Bergmann <arnd@arndb.de>
Mon, 21 Jul 2025 16:04:15 +0000 (18:04 +0200)
struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: Andrea della Porta <andrea.porta@suse.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
drivers/pinctrl/pinctrl-rp1.c

index d300f28c52cd0ced9e3f0459342bd1dd663ff848..6080b57a5d8780fa6293ace11d0756ba8cf8fcd2 100644 (file)
@@ -779,12 +779,14 @@ static int rp1_gpio_get(struct gpio_chip *chip, unsigned int offset)
        return ret;
 }
 
-static void rp1_gpio_set(struct gpio_chip *chip, unsigned int offset, int value)
+static int rp1_gpio_set(struct gpio_chip *chip, unsigned int offset, int value)
 {
        struct rp1_pin_info *pin = rp1_get_pin(chip, offset);
 
        if (pin)
                rp1_set_value(pin, value);
+
+       return 0;
 }
 
 static int rp1_gpio_get_direction(struct gpio_chip *chip, unsigned int offset)
@@ -849,7 +851,7 @@ static const struct gpio_chip rp1_gpio_chip = {
        .direction_output = rp1_gpio_direction_output,
        .get_direction = rp1_gpio_get_direction,
        .get = rp1_gpio_get,
-       .set = rp1_gpio_set,
+       .set_rv = rp1_gpio_set,
        .base = -1,
        .set_config = rp1_gpio_set_config,
        .ngpio = RP1_NUM_GPIOS,