]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
media: hantro: h264: Get the correct fallback reference buffer
authorEzequiel Garcia <ezequiel@collabora.com>
Mon, 27 Jul 2020 17:05:37 +0000 (19:05 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 29 Oct 2020 09:07:18 +0000 (10:07 +0100)
[ Upstream commit 6d9e8cd0553bb03e8ab9d4d2d7d17f3fb639bd86 ]

If the bitstream and the application are incorrectly configuring
the reference pictures, the hardware will need to fallback
to using some other reference picture.

When the post-processor is enabled, the fallback buffer
should be a shadow buffer (postproc.dec_q), and not a
CAPTURE queue buffer, since the latter is post-processed
and not really the output of the decoder core.

Fixes: 8c2d66b036c77 ("media: hantro: Support color conversion via post-processing")
Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/staging/media/hantro/hantro_h264.c

index d561f125085a7a10b8c1a8eccae308f313d3c541..d72ebbd17a69209a9bfdf304802a7f5b5f21baba 100644 (file)
@@ -327,7 +327,7 @@ dma_addr_t hantro_h264_get_ref_buf(struct hantro_ctx *ctx,
                 */
                dst_buf = hantro_get_dst_buf(ctx);
                buf = &dst_buf->vb2_buf;
-               dma_addr = vb2_dma_contig_plane_dma_addr(buf, 0);
+               dma_addr = hantro_get_dec_buf_addr(ctx, buf);
        }
 
        return dma_addr;