postgres checks for string/int port ID, converts to int for pg2 and string for pg1

diff --git a/lib/sqlalchemy/databases/postgres.py b/lib/sqlalchemy/databases/postgres.py
index da8954116159f69ed3d23a42750f3c6a756948f6..3a29186842c09a677fc28d2dd84d3800804af9a2 100644 (file)
--- a/lib/sqlalchemy/databases/postgres.py
+++ b/lib/sqlalchemy/databases/postgres.py
@@ -126,6 +126,12 @@ class PGSQLEngine(ansisql.ANSISQLEngine):
         except:
             self.version = 1
         self.opts = opts or {}
+        if self.opts.has_key('port'):
+            if self.version == 2:
+                self.opts['port'] = int(self.opts['port'])
+            else:
+                self.opts['port'] = str(self.opts['port'])
+                
         ansisql.ANSISQLEngine.__init__(self, **params)
 
     def connect_args(self):

diff --git a/test/testbase.py b/test/testbase.py
index 825d540fa471f9c970935ba7b207eecb63d8116a..e6e2e8ef57b78a7f4d3689fdb9896cd070e062e5 100644 (file)
--- a/test/testbase.py
+++ b/test/testbase.py
@@ -29,7 +29,8 @@ def parse_argv():
     elif DBTYPE == 'sqlite_file':
         db = engine.create_engine('sqlite://filename=querytest.db', echo=echo, default_ordering=True)
     elif DBTYPE == 'postgres':
-        db = engine.create_engine('postgres://database=test&host=127.0.0.1&user=scott&password=tiger', echo=echo, default_ordering=True)
+        db = engine.create_engine('postgres://database=test&port=5432&host=127.0.0.1&user=scott&password=tiger',
+         echo=echo, default_ordering=True)
     elif DBTYPE == 'mysql':
         db = engine.create_engine('mysql://db=test&host=127.0.0.1&user=scott&passwd=tiger', echo=echo, default_ordering=True)
     elif DBTYPE == 'oracle':