]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
lib-storage: list - Remove extra rmdir
authorAki Tuomi <aki.tuomi@open-xchange.com>
Wed, 27 Sep 2023 09:39:28 +0000 (12:39 +0300)
committerAki Tuomi <aki.tuomi@open-xchange.com>
Thu, 28 Sep 2023 09:12:37 +0000 (12:12 +0300)
It's unnecessary and makes deletion fail if the first rmdir
already succeeded.

Broken in 97ffd8e0b0374b9ccbbc788cf796e15d021ad090

src/lib-storage/list/mailbox-list-delete.c

index 6b9c0c84adb7ded361aabc483d82a5c2f0c11e3d..e59ca09ea1f7e483ae482af4e8c3982035585b52 100644 (file)
@@ -236,7 +236,7 @@ int mailbox_list_delete_mailbox_nonrecursive(struct mailbox_list *list,
                        i_sleep_msecs(100);
                        ret = rmdir(path);
                }
-               if (rmdir(path) == 0)
+               if (ret == 0)
                        unlinked_something = TRUE;
                else if (errno == ENOENT) {
                        /* race condition with another process, which finished