]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
coredump: directly return
authorChristian Brauner <brauner@kernel.org>
Thu, 12 Jun 2025 13:25:32 +0000 (15:25 +0200)
committerChristian Brauner <brauner@kernel.org>
Mon, 7 Jul 2025 10:24:50 +0000 (12:24 +0200)
instead of jumping to a pointless cleanup label.

Link: https://lore.kernel.org/20250612-work-coredump-massage-v1-18-315c0c34ba94@kernel.org
Signed-off-by: Christian Brauner <brauner@kernel.org>
fs/coredump.c

index 68da77d00170cf8ca486009de54b3033c84bef6a..b2e9ac34d9a3ab39f0b5bed3a322e90d3e5bd6aa 100644 (file)
@@ -1095,13 +1095,13 @@ void vfs_coredump(const kernel_siginfo_t *siginfo)
 
        binfmt = mm->binfmt;
        if (!binfmt || !binfmt->core_dump)
-               goto fail;
+               return;
        if (!__get_dumpable(cprm.mm_flags))
-               goto fail;
+               return;
 
        cred = prepare_creds();
        if (!cred)
-               goto fail;
+               return;
        /*
         * We cannot trust fsuid as being the "true" uid of the process
         * nor do we know its entire history. We only know it was tainted
@@ -1194,7 +1194,6 @@ fail_unlock:
        revert_creds(old_cred);
 fail_creds:
        put_cred(cred);
-fail:
        return;
 }