]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
util: use g_autofree in virSCSIHostGetUniqueId
authorJán Tomko <jtomko@redhat.com>
Wed, 4 Nov 2020 11:08:19 +0000 (12:08 +0100)
committerJán Tomko <jtomko@redhat.com>
Fri, 6 Nov 2020 14:03:39 +0000 (15:03 +0100)
Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Erik Skultety <eskultet@redhat.com>
src/util/virscsihost.c

index c259e630003a76dfafd8a997319fbde8557f4f7b..4d314c3cebbb42509a30eeb972a55d526158ccf9 100644 (file)
@@ -46,17 +46,16 @@ int
 virSCSIHostGetUniqueId(const char *sysfs_prefix,
                        int host)
 {
-    char *sysfs_path = NULL;
+    g_autofree char *sysfs_path = NULL;
     char *p = NULL;
-    int ret = -1;
-    char *buf = NULL;
+    g_autofree char *buf = NULL;
     int unique_id;
 
     sysfs_path = g_strdup_printf("%s/host%d/unique_id",
                                  sysfs_prefix ? sysfs_prefix : SYSFS_SCSI_HOST_PATH, host);
 
     if (virFileReadAll(sysfs_path, 1024, &buf) < 0)
-        goto cleanup;
+        return -1;
 
     if ((p = strchr(buf, '\n')))
         *p = '\0';
@@ -65,15 +64,10 @@ virSCSIHostGetUniqueId(const char *sysfs_prefix,
         virReportError(VIR_ERR_INTERNAL_ERROR,
                        _("unable to parse unique_id: %s"), buf);
 
-        goto cleanup;
+        return -1;
     }
 
-    ret = unique_id;
-
- cleanup:
-    VIR_FREE(sysfs_path);
-    VIR_FREE(buf);
-    return ret;
+    return unique_id;
 }