]> git.ipfire.org Git - thirdparty/postgresql.git/commitdiff
Remove incorrect commented out code
authorPeter Eisentraut <peter@eisentraut.org>
Thu, 22 Jan 2026 11:41:40 +0000 (12:41 +0100)
committerPeter Eisentraut <peter@eisentraut.org>
Thu, 22 Jan 2026 11:44:07 +0000 (12:44 +0100)
These calls, if activated, are happening before null checks, so they
are not correct.  Also, the "in" variable is shadowed later.  Remove
them to avoid confusion and bad examples.

Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi>
Reviewed-by: David Geier <geidav.pg@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/328e4371-9a4c-4196-9df9-1f23afc900df%40eisentraut.org

src/backend/utils/adt/jsonfuncs.c

index f2f1f59013a2c1a504106da36f9abae38efccced..1e5b60801e4c2f9db2bbaa337df13797f2474eeb 100644 (file)
@@ -4898,10 +4898,6 @@ jsonb_set(PG_FUNCTION_ARGS)
 Datum
 jsonb_set_lax(PG_FUNCTION_ARGS)
 {
-       /* Jsonb           *in = PG_GETARG_JSONB_P(0); */
-       /* ArrayType  *path = PG_GETARG_ARRAYTYPE_P(1); */
-       /* Jsonb          *newval = PG_GETARG_JSONB_P(2); */
-       /* bool         create = PG_GETARG_BOOL(3); */
        text       *handle_null;
        char       *handle_val;