keymgr: avoid segfault when using import-pem on a malformed key

Co-authored-by: Hanno Böck <hanno@hboeck.de>

diff --git a/src/utils/keymgr/functions.c b/src/utils/keymgr/functions.c
index bbb2f8faf1b641ec4cde54fc2920b071ff09b790..df00464aaeeb3bb602c307165de6502026222470 100644 (file)
--- a/src/utils/keymgr/functions.c
+++ b/src/utils/keymgr/functions.c
@@ -501,9 +501,12 @@ fail:
 
 static void err_import_key(char *keyid, const char *file)
 {
+       assert(file != NULL);
+
        ERR2("failed to get key%s%s from %s%s",
-            *keyid == '\0' ? "" : " ", keyid,
-            *file == '\0' ? "the keystore" : "file ", file);
+            (keyid == NULL || *keyid == '\0') ? "" : " ",
+            (keyid == NULL) ? "" : keyid,
+            (*file == '\0') ? "the keystore" : "file ", file );
 }
 
 static int import_key(kdnssec_ctx_t *ctx, unsigned backend, const char *param,