]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
rpc_server: Use make_base_pipes_struct() in dcesrv_ncacn_accept_step2()
authorVolker Lendecke <vl@samba.org>
Mon, 11 Jan 2021 20:32:52 +0000 (21:32 +0100)
committerVolker Lendecke <vl@samba.org>
Thu, 14 Jan 2021 13:29:35 +0000 (13:29 +0000)
make_server_pipes_struct() is just a simple wrapper.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Samuel Cabrero <scabrero@samba.org>
source3/rpc_server/rpc_server.c

index e65d4a1b7c6e64c8c2abc232c111fbe59dad7313..f846c659be2f8281299e10c86747e0ee890ac0fc 100644 (file)
@@ -896,7 +896,6 @@ static void dcesrv_ncacn_accept_step2(struct dcerpc_ncacn_conn *ncacn_conn)
        uid_t uid;
        gid_t gid;
        int rc;
-       int sys_errno;
        enum dcerpc_transport_t transport = dcerpc_binding_get_transport(
                        ncacn_conn->endpoint->ep_description);
        const char *endpoint = dcerpc_binding_get_string_option(
@@ -973,18 +972,17 @@ static void dcesrv_ncacn_accept_step2(struct dcerpc_ncacn_conn *ncacn_conn)
                }
        }
 
-       rc = make_server_pipes_struct(ncacn_conn,
-                                     ncacn_conn->msg_ctx,
-                                     pipe_name,
-                                     transport,
-                                     ncacn_conn->remote_client_addr,
-                                     ncacn_conn->local_server_addr,
-                                     &ncacn_conn->p,
-                                     &sys_errno);
-       if (rc < 0) {
-               DBG_ERR("Failed to create pipe struct: %s",
-                       strerror(sys_errno));
-               ncacn_terminate_connection(ncacn_conn, strerror(sys_errno));
+       rc = make_base_pipes_struct(ncacn_conn,
+                                   ncacn_conn->msg_ctx,
+                                   pipe_name,
+                                   transport,
+                                   ncacn_conn->remote_client_addr,
+                                   ncacn_conn->local_server_addr,
+                                   &ncacn_conn->p);
+       if (rc != 0) {
+               const char *errstr = strerror(rc);
+               DBG_ERR("Failed to create pipe struct: %s\n", errstr);
+               ncacn_terminate_connection(ncacn_conn, errstr);
                return;
        }