]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
Fix warning about unsupported cookie flags in QEMU driver
authorDaniel P. Berrange <berrange@redhat.com>
Fri, 3 May 2013 09:55:49 +0000 (10:55 +0100)
committerDaniel P. Berrange <berrange@redhat.com>
Fri, 3 May 2013 13:06:15 +0000 (14:06 +0100)
The QEMU migration code unconditionally sets the 'persistent'
cookie flag on the source host. The dest host, however, only
allows it during parsing if VIR_MIGRATE_PERSIST_DEST was
set. Make the source host only set it if this flag is
present.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
src/qemu/qemu_migration.c

index 0732614f762e5b5a0578c98ff97bdaf104934f73..d50099cd7fd18ea4cbbf560afc5d547b707adf9c 100644 (file)
@@ -2941,8 +2941,9 @@ cleanup:
         VIR_FORCE_CLOSE(fd);
     }
 
-    cookieFlags |= (QEMU_MIGRATION_COOKIE_PERSISTENT |
-                    QEMU_MIGRATION_COOKIE_NETWORK);
+    cookieFlags |= QEMU_MIGRATION_COOKIE_NETWORK;
+    if (flags & VIR_MIGRATE_PERSIST_DEST)
+        cookieFlags |= QEMU_MIGRATION_COOKIE_PERSISTENT;
     if (ret == 0 &&
         qemuMigrationBakeCookie(mig, driver, vm, cookieout,
                                 cookieoutlen, cookieFlags) < 0) {