s4:kdc: Return an error code if sdb_entry_to_hdb_entry() fails

This condition was written backwards — if samba_kdc_fetch() returned
zero, we would ignore any error code returned by
sdb_entry_to_hdb_entry().

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

diff --git a/source4/kdc/hdb-samba4.c b/source4/kdc/hdb-samba4.c
index efe2f5316d95348a3f133183876ddf406ad451f3..b6c7b2a4bba0f0e7a877307279748285d1a9c0d8 100644 (file)
--- a/source4/kdc/hdb-samba4.c
+++ b/source4/kdc/hdb-samba4.c
@@ -178,7 +178,7 @@ static krb5_error_code hdb_samba4_fetch_kvno(krb5_context context, HDB *db,
        ret = sdb_entry_to_hdb_entry(context, &sentry, entry);
        sdb_entry_free(&sentry);
 
-       if (code != 0 && ret != 0) {
+       if (code == 0) {
                code = ret;
        }