]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
aarch64: PR target/108140 Handle NULL target in data intrinsic expansion
authorKyrylo Tkachov <kyrylo.tkachov@arm.com>
Mon, 19 Dec 2022 11:16:47 +0000 (11:16 +0000)
committerKyrylo Tkachov <kyrylo.tkachov@arm.com>
Tue, 10 Jan 2023 10:24:53 +0000 (10:24 +0000)
In this PR we ICE when expanding the __rbit builtin with a NULL target rtx.
I *think* that only happens when the result is unused and hence maybe we shouldn't be expanding
any RTL at all, but the ICE here is easily fixed by deriving the mode from the type of the expression
rather than the target.

This patch does that.
Bootstrapped and tested on aarch64-none-linux-gnu.

gcc/ChangeLog:

PR target/108140
* config/aarch64/aarch64-builtins.cc
(aarch64_expand_builtin_data_intrinsic): Handle NULL target.

gcc/testsuite/ChangeLog:

PR target/108140
* gcc.target/aarch64/acle/pr108140.c: New test.

(cherry picked from commit 98756bcbe27647f263f2b312d1d933d70cf56ba9)

gcc/config/aarch64/aarch64-builtins.cc
gcc/testsuite/gcc.target/aarch64/acle/pr108140.c [new file with mode: 0644]

index 1b0db677f34189b1a0196a07210f601a8b8ddb26..60966fef09977eb1419a5ee75c674638fc952d76 100644 (file)
@@ -2437,7 +2437,7 @@ static rtx
 aarch64_expand_builtin_data_intrinsic (unsigned int fcode, tree exp, rtx target)
 {
   expand_operand ops[2];
-  machine_mode mode = GET_MODE (target);
+  machine_mode mode = TYPE_MODE (TREE_TYPE (exp));
   create_output_operand (&ops[0], target, mode);
   create_input_operand (&ops[1], expand_normal (CALL_EXPR_ARG (exp, 0)), mode);
   enum insn_code icode;
diff --git a/gcc/testsuite/gcc.target/aarch64/acle/pr108140.c b/gcc/testsuite/gcc.target/aarch64/acle/pr108140.c
new file mode 100644 (file)
index 0000000..967928a
--- /dev/null
@@ -0,0 +1,15 @@
+/* PR target/108140  */
+/* { dg-do compile } */
+/* { dg-options "-O2" } */
+
+#include<arm_acle.h>
+
+int
+main(int argc, char *argv[])
+{
+       unsigned long long input = argc-1;
+       unsigned long long v = __clz(__rbit(input));
+       __builtin_printf("%d %d\n", argc, v >= 64 ? 123 : 456);
+       return 0;
+}
+