]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
crypto: caam - Fix the pointer passed to caam_qi_shutdown()
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sun, 15 Sep 2024 10:22:12 +0000 (12:22 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 5 Dec 2024 12:52:49 +0000 (13:52 +0100)
[ Upstream commit ad980b04f51f7fb503530bd1cb328ba5e75a250e ]

The type of the last parameter given to devm_add_action_or_reset() is
"struct caam_drv_private *", but in caam_qi_shutdown(), it is casted to
"struct device *".

Pass the correct parameter to devm_add_action_or_reset() so that the
resources are released as expected.

Fixes: f414de2e2fff ("crypto: caam - use devres to de-initialize QI")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/crypto/caam/qi.c

index ba8fb5d8a7b265044703499ff65599e166354149..dcb9069a254c7871f125ec623f5460ebe69ae1a5 100644 (file)
@@ -793,7 +793,7 @@ int caam_qi_init(struct platform_device *caam_pdev)
 
        caam_debugfs_qi_init(ctrlpriv);
 
-       err = devm_add_action_or_reset(qidev, caam_qi_shutdown, ctrlpriv);
+       err = devm_add_action_or_reset(qidev, caam_qi_shutdown, qidev);
        if (err)
                goto fail2;