]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
media: rzg2l-cru: Do not use irqsave when not needed
authorJacopo Mondi <jacopo.mondi+renesas@ideasonboard.com>
Thu, 12 Feb 2026 14:38:38 +0000 (15:38 +0100)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Tue, 19 May 2026 07:01:49 +0000 (09:01 +0200)
The return_unused_buffers() and rzg2l_cru_buffer_queue() functions
are never called from an interrupt context, hence they do not need to
use the irqsave version of the spinlock primitives.

Signed-off-by: Jacopo Mondi <jacopo.mondi+renesas@ideasonboard.com>
Tested-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
Reviewed-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c

index 96c71f1357f8067591f4fdea655e0cf87f5d471d..b2d1b6a4aaaa986313d1e64bfaa27788ad7536fb 100644 (file)
@@ -112,7 +112,7 @@ static void return_unused_buffers(struct rzg2l_cru_dev *cru,
        struct rzg2l_cru_buffer *buf, *node;
        unsigned int i;
 
-       guard(spinlock_irqsave)(&cru->qlock);
+       guard(spinlock_irq)(&cru->qlock);
 
        for (i = 0; i < cru->num_buf; i++) {
                if (cru->queue_buf[i]) {
@@ -165,7 +165,7 @@ static void rzg2l_cru_buffer_queue(struct vb2_buffer *vb)
        struct vb2_v4l2_buffer *vbuf = to_vb2_v4l2_buffer(vb);
        struct rzg2l_cru_dev *cru = vb2_get_drv_priv(vb->vb2_queue);
 
-       guard(spinlock_irqsave)(&cru->qlock);
+       guard(spinlock_irq)(&cru->qlock);
        list_add_tail(to_buf_list(vbuf), &cru->buf_list);
 }