]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commitdiff
Fix "Ambiguous column name" error on FK reflection
authorGord Thompson <gord@gordthompson.com>
Mon, 14 Mar 2022 17:26:54 +0000 (11:26 -0600)
committermike bayer <mike_mp@zzzcomputing.com>
Mon, 14 Mar 2022 18:51:05 +0000 (18:51 +0000)
Fixes: #7812
Change-Id: Ic16eff9a9201d34515cb8eb884270eced4e1196a

doc/build/changelog/unreleased_14/7812.rst [new file with mode: 0644]
lib/sqlalchemy/dialects/mssql/base.py

diff --git a/doc/build/changelog/unreleased_14/7812.rst b/doc/build/changelog/unreleased_14/7812.rst
new file mode 100644 (file)
index 0000000..7e28428
--- /dev/null
@@ -0,0 +1,7 @@
+.. change::
+    :tags: bug, mssql, regression
+    :tickets: 7812
+
+    Fixed regression caused by :ticket:`7160` where FK reflection on a very
+    old database (compatibility level 80: SQL Server 2000) causes an
+    "Ambiguous column name" error. Patch courtesy of @Lin-Your.
index 8c44c0b2d2b88abc801f6a8173fc96646273e0c2..dd792f70d7fb619301f5db799c0dbe2842ba2ab5 100644 (file)
@@ -3422,7 +3422,8 @@ index_info AS (
             AND index_info.index_name = fk_info.unique_constraint_name
             AND index_info.ordinal_position = fk_info.ordinal_position
 
-    ORDER BY constraint_schema, constraint_name, ordinal_position
+    ORDER BY fk_info.constraint_schema, fk_info.constraint_name,
+        fk_info.ordinal_position
 """
             )
             .bindparams(