]> git.ipfire.org Git - thirdparty/hostap.git/commitdiff
MBSSID: Use DTIM Count 0 in the Beacon template for nontransmitted BSSID
authorJouni Malinen <quic_jouni@quicinc.com>
Tue, 7 Nov 2023 08:44:28 +0000 (10:44 +0200)
committerJouni Malinen <j@w1.fi>
Tue, 7 Nov 2023 08:44:28 +0000 (10:44 +0200)
The driver is expected to update the DTIM Count field for each BSS that
corresponds to a nontransmitted BSSID. Initialized this value to 0 in
the Beacon frame template so that the DTIM count would be somewhat
functional even if the driver were not to update this.

Signed-off-by: Jouni Malinen <quic_jouni@quicinc.com>
src/ap/ieee802_11.c

index 889348762717a184a75a8bc529ca75083ecf5dd5..d48185a17189d9df5f5b10d467be414f329b779d 100644 (file)
@@ -7763,7 +7763,13 @@ static u8 * hostapd_eid_mbssid_elem(struct hostapd_data *hapd, u8 *eid, u8 *end,
                            (conf->dtim_period % elem_count))
                                conf->dtim_period = elem_count;
                        *eid++ = conf->dtim_period;
-                       *eid++ = 0xFF; /* DTIM Count */
+                       /* The driver is expected to update the DTIM Count
+                        * field for each BSS that corresponds to a
+                        * nontransmitted BSSID. The value is initialized to
+                        * 0 here so that the DTIM count would be somewhat
+                        * functional even if the driver were not to update
+                        * this. */
+                       *eid++ = 0; /* DTIM Count */
                } else {
                        /* Probe Request frame does not include DTIM Period and
                         * DTIM Count fields. */