vala: Ownership transfer of inline-allocated array is not allowed

Fixes https://gitlab.gnome.org/GNOME/vala/issues/931

diff --git a/tests/Makefile.am b/tests/Makefile.am
index 669dccecb4aa4de371afe4ba9f8cf4fd4a84bc65..eaf147097156b58b8ac9e712a6cbf03ce0a3750c 100644 (file)
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -87,6 +87,7 @@ TESTS = \
        arrays/inline-field.test \
        arrays/inline-local-instantiation.test \
        arrays/inline-local-variable.test \
+       arrays/inline-ownership-transfer.test \
        arrays/inline-parameter.test \
        arrays/inline-struct.vala \
        arrays/inline-struct-field.test \

diff --git a/tests/arrays/inline-ownership-transfer.test b/tests/arrays/inline-ownership-transfer.test
new file mode 100644 (file)
index 0000000..f274a45
--- /dev/null
+++ b/tests/arrays/inline-ownership-transfer.test
@@ -0,0 +1,6 @@
+Invalid Code
+
+void main () {
+       string foo[23];
+       var bar = (owned) foo;
+}

diff --git a/vala/valareferencetransferexpression.vala b/vala/valareferencetransferexpression.vala
index f455446bf174259998f1ae593ee14bb16ca4eded..4de0f49d15b1033640dcd1bdb58082fea1e8d475 100644 (file)
--- a/vala/valareferencetransferexpression.vala
+++ b/vala/valareferencetransferexpression.vala
@@ -100,6 +100,12 @@ public class Vala.ReferenceTransferExpression : Expression {
                        return false;
                }
 
+               if (inner.value_type is ArrayType && ((ArrayType) inner.value_type).inline_allocated) {
+                       error = true;
+                       Report.error (source_reference, "Ownership of inline-allocated array cannot be transferred");
+                       return false;
+               }
+
                var is_owned_delegate = inner.value_type is DelegateType && inner.value_type.value_owned;
                if (!inner.value_type.is_disposable ()
                    && !(inner.value_type is PointerType)