]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
buildtools: Properly set global variable
authorJoseph Sutton <josephsutton@catalyst.net.nz>
Tue, 29 Aug 2023 08:48:14 +0000 (20:48 +1200)
committerAndrew Bartlett <abartlet@samba.org>
Wed, 30 Aug 2023 02:15:28 +0000 (02:15 +0000)
Since we didn’t declare ‘old_refill_task_list’ as global, we were just
assigning a value to a local variable that was destroyed after we
returned from this function. We clearly intended instead to assign to a
global variable of the same name.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
buildtools/wafsamba/stale_files.py

index 78efea424fd889ab7940770016a6854a0982f775..ac2c2a74194dda2bf5b0cf5e0adf0ab2fc374eed 100644 (file)
@@ -107,6 +107,7 @@ def replace_refill_task_list(self):
 
 def AUTOCLEANUP_STALE_FILES(bld):
     """automatically clean up any files in bin that shouldn't be there"""
+    global old_refill_task_list
     old_refill_task_list = Parallel.refill_task_list
     Parallel.refill_task_list = replace_refill_task_list
     Parallel.bld = bld