]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ASoC: fsl: imx-rpmsg: use snd_soc_find_dai_with_mutex() in probe
authorZiyi Guo <n7l8m4@u.northwestern.edu>
Thu, 5 Feb 2026 05:24:29 +0000 (05:24 +0000)
committerMark Brown <broonie@kernel.org>
Thu, 5 Feb 2026 17:29:00 +0000 (17:29 +0000)
imx_rpmsg_probe() calls snd_soc_find_dai() without holding client_mutex.
However, snd_soc_find_dai() has lockdep_assert_held(&client_mutex)
indicating callers must hold this lock, as the function iterates over the
global component list.

All other callers of snd_soc_find_dai() either hold client_mutex via the
snd_soc_bind_card() path or use the snd_soc_find_dai_with_mutex() wrapper.

Use snd_soc_find_dai_with_mutex() instead to fix the missing lock
protection.

Signed-off-by: Ziyi Guo <n7l8m4@u.northwestern.edu>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Link: https://patch.msgid.link/20260205052429.4046903-1-n7l8m4@u.northwestern.edu
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/fsl/imx-rpmsg.c

index 53f04d1f32806d039954ac1e6200747666f56beb..76a8e68c1b620c69b7b49a700b7ccbaec21f8525 100644 (file)
@@ -145,7 +145,7 @@ static int imx_rpmsg_probe(struct platform_device *pdev)
        data->dai.ignore_pmdown_time = 1;
 
        data->dai.cpus->dai_name = pdev->dev.platform_data;
-       cpu_dai = snd_soc_find_dai(data->dai.cpus);
+       cpu_dai = snd_soc_find_dai_with_mutex(data->dai.cpus);
        if (!cpu_dai) {
                ret = -EPROBE_DEFER;
                goto fail;