]> git.ipfire.org Git - thirdparty/kmod.git/commitdiff
libkmod/libkmod-signature: remove set but unused sig_alg
authorEmil Velikov <emil.l.velikov@gmail.com>
Sun, 15 Feb 2026 21:34:01 +0000 (21:34 +0000)
committerLucas De Marchi <demarchi@kernel.org>
Wed, 22 Apr 2026 13:54:42 +0000 (08:54 -0500)
The function PKCS7_SIGNER_INFO_get0_algs takes three output arguments,
all of which are optional. Remove the set but unused sig_alg.

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Link: https://github.com/kmod-project/kmod/pull/427
Signed-off-by: Lucas De Marchi <demarchi@kernel.org>
libkmod/libkmod-signature.c

index 04ef549879b4d18f0809e12747688262873f960b..698b02e5833e4fd1baef1706d71987da287858a9 100644 (file)
@@ -162,7 +162,6 @@ static bool fill_pkcs7(const char *mem, off_t size, size_t sig_len,
        ASN1_OCTET_STRING *sig;
        BIGNUM *sno_bn;
        X509_ALGOR *dig_alg;
-       X509_ALGOR *sig_alg;
        const ASN1_OBJECT *o;
        BIO *in;
        int len;
@@ -203,7 +202,7 @@ static bool fill_pkcs7(const char *mem, off_t size, size_t sig_len,
        if (sig == NULL)
                goto err;
 
-       PKCS7_SIGNER_INFO_get0_algs(si, NULL, &dig_alg, &sig_alg);
+       PKCS7_SIGNER_INFO_get0_algs(si, NULL, &dig_alg, NULL);
 
        sig_info->sig = (const char *)ASN1_STRING_get0_data(sig);
        sig_info->sig_len = ASN1_STRING_length(sig);