]> git.ipfire.org Git - people/ms/linux.git/commitdiff
bonding: Fix slave selection bug.
authorHillf Danton <dhillf@gmail.com>
Fri, 10 Dec 2010 18:54:11 +0000 (18:54 +0000)
committerWilly Tarreau <w@1wt.eu>
Mon, 10 Jun 2013 09:43:27 +0000 (11:43 +0200)
The returned slave is incorrect, if the net device under check is not
charged yet by the master.

Signed-off-by: Hillf Danton <dhillf@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
(cherry picked from commit af3e5bd5f650163c2e12297f572910a1af1b8236)
Signed-off-by: Willy Tarreau <w@1wt.eu>
drivers/net/bonding/bonding.h

index 68247714466faf4be698cdba6379954d4bc5035f..5d127fcc8cee51e7dfc0e44e53f864b7120f28fb 100644 (file)
@@ -236,11 +236,11 @@ static inline struct slave *bond_get_slave_by_dev(struct bonding *bond, struct n
 
        bond_for_each_slave(bond, slave, i) {
                if (slave->dev == slave_dev) {
-                       break;
+                       return slave;
                }
        }
 
-       return slave;
+       return 0;
 }
 
 static inline struct bonding *bond_get_bond_by_slave(struct slave *slave)