]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net: wan: fsl_ucc_hdlc: fix ucc_hdlc_remove
authorHolger Brunck <holger.brunck@hitachienergy.com>
Wed, 29 Apr 2026 11:42:08 +0000 (13:42 +0200)
committerJakub Kicinski <kuba@kernel.org>
Sat, 2 May 2026 17:14:06 +0000 (10:14 -0700)
If the driver is used in a non tdm mode priv->utdm is a NULL pointer.
Therefore we need to check this pointer first before checking si_regs.

Fixes: c19b6d246a35 ("drivers/net: support hdlc function for QE-UCC")
Signed-off-by: Holger Brunck <holger.brunck@hitachienergy.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/wan/fsl_ucc_hdlc.c

index 8155e92af14e23d3e83625de3d18ece56dbac006..15bfb78381d4cb749b4114558679fc5af86a34de 100644 (file)
@@ -1250,12 +1250,12 @@ static void ucc_hdlc_remove(struct platform_device *pdev)
 
        uhdlc_memclean(priv);
 
-       if (priv->utdm->si_regs) {
+       if (priv->utdm && priv->utdm->si_regs) {
                iounmap(priv->utdm->si_regs);
                priv->utdm->si_regs = NULL;
        }
 
-       if (priv->utdm->siram) {
+       if (priv->utdm && priv->utdm->siram) {
                iounmap(priv->utdm->siram);
                priv->utdm->siram = NULL;
        }