]> git.ipfire.org Git - thirdparty/iproute2.git/commitdiff
devlink: No need for this self-assignment
authorPhil Sutter <phil@nwl.cc>
Thu, 17 Aug 2017 17:09:25 +0000 (19:09 +0200)
committerStephen Hemminger <stephen@networkplumber.org>
Tue, 22 Aug 2017 00:12:21 +0000 (17:12 -0700)
dl_argv_handle_both() will either assign to handle_bit or error out in
which case the variable is not used by the caller.

Signed-off-by: Phil Sutter <phil@nwl.cc>
Acked-by: Jiri Pirko <jiri@mellanox.com>
devlink/devlink.c

index 7602970bc58a8e0a25da1517bedd4b9ed695703b..5b325ce6c657c428f9ac4040ed777e3b607b3c6c 100644 (file)
@@ -779,7 +779,7 @@ static int dl_argv_parse(struct dl *dl, uint32_t o_required,
        int err;
 
        if (o_required & DL_OPT_HANDLE && o_required & DL_OPT_HANDLEP) {
-               uint32_t handle_bit = handle_bit;
+               uint32_t handle_bit;
 
                err = dl_argv_handle_both(dl, &opts->bus_name, &opts->dev_name,
                                          &opts->port_index, &handle_bit);