fclose destroys file descriptor Closes #1390

diff --git a/src/lib/missing.c b/src/lib/missing.c
index 5782bb7809c2b60ff1a55580bedadd4256366cbc..fd3e636e3835106c434d7e121ad5ebf34fc17c36 100644 (file)
--- a/src/lib/missing.c
+++ b/src/lib/missing.c
@@ -196,12 +196,19 @@ int vdprintf (int fd, const char *format, va_list args)
 {
        int     ret;
        FILE    *fp;
+       int     dup_fd;
+
+       dup_fd = dup(fd);
+       if (dup_fd < 0) return -1;
 
        fp = fdopen(fd, "w");
-       if (!fp) return -1;
+       if (!fp) {
+               close(dup_fd);
+               return -1;
+       }
 
        ret = vfprintf(fp, format, args);
-       fclose(fp);
+       fclose(fp);     /* Also closes dup_fd */
 
        return ret;
 }